Fix http_acl regex to capture username with space #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With chef-boneyard#295 http_acl LWRP now supports username with spaces, but due to the current regex to capture username, the execution is not idempotent. Changing the regex to capture everything after space characters fix it.
|
👍 |
|
👍 Would be nice to get a test for this as well, but that shouldn't block merging. |
mwrock
added a commit
that referenced
this pull request
Dec 21, 2015
Fix http_acl regex to capture username with space
|
@smurawski I'm working on a tiny new feature for this LWRP and I'll provide some test cases |
|
I also added a test for basic functionality bf51eb3 |
|
We are looking to relase late AM today Pacific time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #295 http_acl LWRP now supports username with spaces, but due to the current regex to capture username, the execution is not idempotent.
Changing the regex to capture everything after space characters fix it.
cc: @aboten