Task enable disable #129
Task enable disable #129
Conversation
| Chef::Log.info "#{@new_resource} task enabled" | ||
| end | ||
| else | ||
| Chef::Log.debug "#{@new_resource} task doesn't exist - nothing to do" |
There was a problem hiding this comment.
I think this should raise an error in this case. You asked Chef to enable a task, and it can't do what you asked.
We've talked about this situation in the past when it comes to services and tend to accept the argument that you should be able to disable services that don't exist because they could be part of a security effort to make sure certain services don't run, but enabling services (or tasks) is a different matter.
There was a problem hiding this comment.
Makes sense, what error would you raise?
There was a problem hiding this comment.
raise Errno::ENOENT, "#{@new_resource}: task does not exist, cannot enable"
|
yeah, let's just toss an exception in there and this is 👍 |
|
Merged to master, with the exception and added windows_task to the new integration test code. Thanks @petewest. |
Add actions to enable and disable windows tasks.