-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support XFS as ebs_raid filesystem. Tweak README. #63
Conversation
This could be generalised to a single mkfs -t #{filesystem} #{md_device} but this approach ensures xfs tools are available if required.
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
So testing against ubuntu-1204, this doesnt actually work. The chef run executes successfully but it doesnt actually properly lay down the filesystem
|
@cwebberOps Hrm. It's been 6 months since I looked at this code and I'm not using that particular setup on AWS either. I'm pretty sure it was working and we were running it in production, but I can only assume something else was at play. I can't guarantee when I'll get the time to look at this, but I'll have a look when I can. |
@bazbremner no worries. I totally understand. |
@@ -390,9 +390,12 @@ def create_raid_disks(mount_point, mount_point_owner, mount_point_group, mount_p | |||
case filesystem | |||
when "ext4" | |||
system("mke2fs -t #{filesystem} -F #{md_device}") | |||
when "xfs" | |||
run_context.include_recipe 'xfs' | |||
system("mkfs -t #{filesystem} #{md_device}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkfs.xfs #{md_device}
is how I normally setup the FS, so I'll test this with my change and resubmit the PR assuming everything works.
@@ -6,3 +6,5 @@ | |||
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
version "2.1.2" | |||
recipe "aws", "Installs the right_aws gem during compile time" | |||
|
|||
depends "xfs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the xfs cookbook only installs xfsdump we can remove this and leave it up to the user to have a system capable of formatting and XFS volume
@bazbremner Thank you so much for your contribution. Apologies for the delay in merging. As we've grown the cookbook team we are working to have a much quicker turn around on these kind of things. |
@iennae no problems - I've also not touched any cookbooks for a while either, such is life. Thanks for merging it! |
This could be generalised to a single
but this approach ensures xfs tools are available if required.