Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

navigation promise should be created before click that leads to navigation #26

Closed
tnolet opened this issue Sep 25, 2018 · 0 comments
Closed
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@tnolet
Copy link
Member

tnolet commented Sep 25, 2018

The promise creation now occurs after the click. It should be like below.

const navigationPromise = page.waitForNavigation()
await page.click('a')
await navigationPromise
@tnolet tnolet added the 🐛 bug Something isn't working label Sep 25, 2018
@tnolet tnolet self-assigned this Sep 25, 2018
@tnolet tnolet added this to the v0.4.1 milestone Sep 25, 2018
@tnolet tnolet closed this as completed in f39dbca Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant