Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add viewport detection #10

Closed
tnolet opened this issue Aug 20, 2018 · 0 comments
Closed

Add viewport detection #10

tnolet opened this issue Aug 20, 2018 · 0 comments
Assignees
@tnolet
Labels
🦾 enhancement New feature or request
Milestone
v0.2.0

Comments

@tnolet
Copy link
Member

tnolet commented Aug 20, 2018

The viewport width / height should be detected add add as a await page.setViewport({ width: 1280, height: 800 }) stanza after spawning the first page.

This is handy because after recording, menus might be invisible as the viewport is not very wide.
@tnolet tnolet added the 🦾 enhancement New feature or request label Aug 20, 2018
@tnolet tnolet added this to the 0.2.0 milestone Aug 20, 2018
@tnolet tnolet self-assigned this Aug 20, 2018
@tnolet tnolet closed this as completed in 5fff05e Aug 21, 2018
tnolet added a commit that referenced this issue Aug 21, 2018
@tnolet
Merge branch 'develop'
bd76ef7 
* develop:
  refactor: make content script injection and event handler attachments idempotent
  refactor: refactor restart vs. cleanup logic
  feat: adds togglable waitForNavigation on navigation attempts.
  refactor: fixes some debug statements
  refactor: replaces css selector library. Closes #5
  feat: sets the viewport before the goto command. Closes #10
  feat: adds the headless true/false option. Closes #9
  fix: fixes not loading of options. Closes #11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tnolet tnolet

Labels
🦾 enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@tnolet