From 80748911aafbc00b45339168db5737d2eb8a70c2 Mon Sep 17 00:00:00 2001 From: Arun Philip Date: Thu, 7 Mar 2024 17:18:48 -0500 Subject: [PATCH 1/2] platform.isAttached should return false if canvas is false-y --- src/platform/platform.dom.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/platform/platform.dom.js b/src/platform/platform.dom.js index 6c4b96d7546..a453692bd28 100644 --- a/src/platform/platform.dom.js +++ b/src/platform/platform.dom.js @@ -383,6 +383,10 @@ export default class DomPlatform extends BasePlatform { * @param {HTMLCanvasElement} canvas */ isAttached(canvas) { + if (!canvas) { + return false; + } + const container = _getParentNode(canvas); return !!(container && container.isConnected); } From bffce3d6b629c6d7561e001e9f0ab8fd880149b2 Mon Sep 17 00:00:00 2001 From: Arun Philip Date: Thu, 7 Mar 2024 17:42:26 -0500 Subject: [PATCH 2/2] change styling to conform to codeclimate linter --- src/helpers/helpers.dom.ts | 2 +- src/platform/platform.dom.js | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/helpers/helpers.dom.ts b/src/helpers/helpers.dom.ts index c83712983ac..e06fefe94a6 100644 --- a/src/helpers/helpers.dom.ts +++ b/src/helpers/helpers.dom.ts @@ -142,7 +142,7 @@ function getContainerSize(canvas: HTMLCanvasElement, width: number, height: numb let maxWidth: number, maxHeight: number; if (width === undefined || height === undefined) { - const container = _getParentNode(canvas); + const container = canvas && _getParentNode(canvas); if (!container) { width = canvas.clientWidth; height = canvas.clientHeight; diff --git a/src/platform/platform.dom.js b/src/platform/platform.dom.js index a453692bd28..4c6f72e425e 100644 --- a/src/platform/platform.dom.js +++ b/src/platform/platform.dom.js @@ -383,11 +383,7 @@ export default class DomPlatform extends BasePlatform { * @param {HTMLCanvasElement} canvas */ isAttached(canvas) { - if (!canvas) { - return false; - } - - const container = _getParentNode(canvas); + const container = canvas && _getParentNode(canvas); return !!(container && container.isConnected); } }