Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update export for tidier import functionality for front end frameworks #5357

Closed
ghost opened this issue Mar 22, 2018 · 1 comment
Closed

Comments

@ghost
Copy link

ghost commented Mar 22, 2018

module.exports = Chart;

currently this export type doesn't support ES6 import syntax that is documented in the documentation.
http://www.chartjs.org/docs/latest/getting-started/integration.html
import Chart from 'chart.js';
and requires import via import * as Chart from 'chart.js';
for universal importation across front end frame works
if an export default was substituted in stead of the module.exports then the documented es6 syntax would be correct.

@simonbrunel
Copy link
Member

Duplicate of #5179

@simonbrunel simonbrunel marked this as a duplicate of #5179 Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants