Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graal] Checkout log an issue in case of large repositories #33

Closed
inishchith opened this issue Jun 4, 2019 · 3 comments · Fixed by #34
Closed

[graal] Checkout log an issue in case of large repositories #33

inishchith opened this issue Jun 4, 2019 · 3 comments · Fixed by #34

Comments

@inishchith
Copy link
Contributor

Issue Scenario: I found this out when I was working on the integration task of Graal with ELK (inishchith/gsoc#4). which causes the checkout log (for the number of commits):

Git repository <repo-path> checked out!

This wouldn't be a good to have in case of repositories of a large number of commits causing a console log for eg. [image attached below on the first run]

Screenshot 2019-06-04 at 6 45 07 PM

@valeriocos @jgbarah I was thinking if we could remove the logger for the checkout purpose (a small change but would lead to better log). Would like to have your thoughts :)

Thanks!

@valeriocos
Copy link
Member

Thank you for reporting this potential issue @inishchith . Maybe we could change the log level to debug (this could be applied to most messages except the one in graal.fetch_items. What do you think ?

@inishchith
Copy link
Contributor Author

@valeriocos Thanks for the quick response!
Yes. That would be better indeed.
I'd propose a fix for this in some time :)

@valeriocos
Copy link
Member

great! thanks @inishchith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants