Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add amounts for price/100ml, mg/euro #139

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Conversation

ItsVipra
Copy link
Contributor

hiya! dog with no ruby knowledge here
I'd like for the drink selection to show the suggested donation/100ml, as well as mg of caffeine/euro.
I've tried implementing this on my own, but i take no guarantees for code functionality. (sorry)

Thoughts and corrections would be much appreciated ❤

@ItsVipra ItsVipra added enhancement question ruby Pull requests that update Ruby code labels May 27, 2023
@ItsVipra ItsVipra marked this pull request as draft May 27, 2023 14:19
@YtvwlD YtvwlD force-pushed the show-additional-drink-info branch from fba9d26 to dacc2e3 Compare May 27, 2023 15:01
@ItsVipra ItsVipra force-pushed the show-additional-drink-info branch 2 times, most recently from a4f8610 to 33af759 Compare May 27, 2023 15:24
@ItsVipra ItsVipra force-pushed the show-additional-drink-info branch from 33af759 to ae61e8b Compare May 27, 2023 15:34
@YtvwlD
Copy link
Member

YtvwlD commented May 27, 2023

It looks like this:
grafik

@YtvwlD YtvwlD marked this pull request as ready for review May 27, 2023 15:41
@YtvwlD YtvwlD requested a review from marudor May 27, 2023 15:41
@YtvwlD YtvwlD merged commit c4701a6 into main Oct 21, 2023
2 checks passed
@YtvwlD YtvwlD deleted the show-additional-drink-info branch October 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement question ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants