-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sequence import #775
fix: sequence import #775
Conversation
bb62bdb
to
b3506d7
Compare
db3350d
to
937058f
Compare
/ok-to-test sha=937058f |
Integration tests failure for 937058f |
well that's a bummer, looks as though something got lost in a merge in the old repo, WIP |
937058f
to
3163818
Compare
296d39f
to
907b57c
Compare
this should be ready to go now |
907b57c
to
e901b85
Compare
@alldoami at your convenience |
116be17
to
480bb46
Compare
480bb46
to
330205f
Compare
3bea04d
to
6dcefa6
Compare
no changes just rebasing to keep up to date |
84b2fdd
to
63277b8
Compare
no changes just rebasing to keep up to date |
/ok-to-test sha=63277b8 |
Integration tests success for 63277b8 |
Sweet! Could you update your branch and we can get this merged? Sorry I don't remember seeing updates on my side! |
63277b8
to
2ad4197
Compare
np! |
2ad4197
to
1708eab
Compare
/ok-to-test sha=1708eab |
Integration tests success for 1708eab |
Also a database/schema change to
https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/db3350d5c9e0a641e80f6c2803c5364658d49584/pkg/resources/sequence.go#L44-L50
as that is what's happening behind the scenes, however it does copy over the current sequence value
https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/b3506d7fd2f3d548a128693d94bc87714492dd83/pkg/resources/sequence.go#L221-L236
Test Plan
existing tests pass changing only the format to include both the database and schema
References