Skip to content

Commit

Permalink
feat: Add manage support cases account grants (#961)
Browse files Browse the repository at this point in the history
  • Loading branch information
gary-beautypie authored Apr 8, 2022
1 parent 2f6fe43 commit 1d1084d
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 11 deletions.
3 changes: 2 additions & 1 deletion pkg/datasources/procedures_acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ func TestAccProcedures(t *testing.T) {
resource.TestCheckResourceAttr("data.snowflake_procedures.t", "database", databaseName),
resource.TestCheckResourceAttr("data.snowflake_procedures.t", "schema", schemaName),
resource.TestCheckResourceAttrSet("data.snowflake_procedures.t", "procedures.#"),
resource.TestCheckResourceAttr("data.snowflake_procedures.t", "procedures.#", "2"),
resource.TestCheckResourceAttr("data.snowflake_procedures.t", "procedures.#", "3"),
// Extra 1 in procedure count above due to ASSOCIATE_SEMANTIC_CATEGORY_TAGS appearing in all "SHOW PROCEDURES IN ..." commands
),
},
},
Expand Down
3 changes: 3 additions & 0 deletions pkg/resources/account_grant.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ var validAccountPrivileges = NewPrivilegeSet(
privilegeMonitorExecution,
privilegeOverrideShareRestrictions,
privilegeExecuteManagedTask,
privilegeOrganizationSupportCases,
privilegeAccountSupportCases,
privilegeUserSupportCases,
)

var accountGrantSchema = map[string]*schema.Schema{
Expand Down
30 changes: 30 additions & 0 deletions pkg/resources/account_grant_acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,33 @@ resource "snowflake_account_grant" "test" {
}
`, role)
}

func TestAcc_AccountGrantManageSupportCases(t *testing.T) {
roleName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))

resource.ParallelTest(t, resource.TestCase{
Providers: providers(),
Steps: []resource.TestStep{
{
Config: accountGrantManageSupportCasesConfig(roleName),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("snowflake_account_grant.test", "privilege", "MANAGE ACCOUNT SUPPORT CASES"),
),
},
},
})
}

func accountGrantManageSupportCasesConfig(role string) string {
return fmt.Sprintf(`
resource "snowflake_role" "test" {
name = "%v"
}
resource "snowflake_account_grant" "test" {
roles = [snowflake_role.test.name]
privilege = "MANAGE ACCOUNT SUPPORT CASES"
}
`, role)
}
23 changes: 13 additions & 10 deletions pkg/resources/privileges.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,19 @@ const (
privilegeApply Privilege = "APPLY"
privilegeAttachPolicy Privilege = "ATTACH POLICY"

privilegeCreateRole Privilege = "CREATE ROLE"
privilegeCreateUser Privilege = "CREATE USER"
privilegeCreateWarehouse Privilege = "CREATE WAREHOUSE"
privilegeCreateDatabase Privilege = "CREATE DATABASE"
privilegeCreateIntegration Privilege = "CREATE INTEGRATION"
privilegeManageGrants Privilege = "MANAGE GRANTS"
privilegeMonitorUsage Privilege = "MONITOR USAGE"
privilegeMonitorExecution Privilege = "MONITOR EXECUTION"
privilegeExecuteTask Privilege = "EXECUTE TASK"
privilegeExecuteManagedTask Privilege = "EXECUTE MANAGED TASK"
privilegeCreateRole Privilege = "CREATE ROLE"
privilegeCreateUser Privilege = "CREATE USER"
privilegeCreateWarehouse Privilege = "CREATE WAREHOUSE"
privilegeCreateDatabase Privilege = "CREATE DATABASE"
privilegeCreateIntegration Privilege = "CREATE INTEGRATION"
privilegeManageGrants Privilege = "MANAGE GRANTS"
privilegeMonitorUsage Privilege = "MONITOR USAGE"
privilegeMonitorExecution Privilege = "MONITOR EXECUTION"
privilegeExecuteTask Privilege = "EXECUTE TASK"
privilegeExecuteManagedTask Privilege = "EXECUTE MANAGED TASK"
privilegeOrganizationSupportCases Privilege = "MANAGE ORGANIZATION SUPPORT CASES"
privilegeAccountSupportCases Privilege = "MANAGE ACCOUNT SUPPORT CASES"
privilegeUserSupportCases Privilege = "MANAGE USER SUPPORT CASES"
)

type PrivilegeSet map[Privilege]struct{}
Expand Down

0 comments on commit 1d1084d

Please sign in to comment.