-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't verify_SSL be true by default? #68
Comments
I think we document it clearly and with justifications for why this is the behavior here: |
Right, I read that and that's a little odd to me that "we turn it off because SSL adds a class in servers by discriminating non-paid certificates" is the default. Maybe we can at least change that bit when https://letsencrypt.org/ is operational later this year? |
I think the minimalist position we decided on is that we're not going to be responsible for the user's trust model. By being in the user's face about it, we make them take an active position about their trust model. Sure, most users will flip on Maybe we should move that up in the docs. Blind trust is a form of security theater, so we don't want to default people into that. |
I'm having a hard time understanding that non-verification of SSL is the good default because blind trust is a bad thing, because skipping SSL verification actually sounds more of a blind trust, from the user's point of view. If that's the goal you're trying to achieve, requiring verify_SSL (either 0 or 1, there's no default) sounds like more correct thing to do, since from the look of the code Note that i'm not actually suggesting that fix above, I still think enabling SSL verification by default (by looking at the host SSL certificate location or |
It's even worse to default to "verify" but fallback with a warning. That's like BACKRONYM for mysql (albeit at the cert name level rather than the TLS level). Either verification has to be on and enforced, or off. If it helps with understanding, the difference is between these:
We don't require people to use SSL. Users choose to provide an https URL. We don't require server name verification. Users choose to set Everything is opt-in. I would feel differently if this was a browser, but it's just a very low-level protocol library. Anything user-facing that uses it can opt into whatever trust model it wants to offer to users. |
OK then. I'll set verify_SSL in my own code. |
I think a false value for verify_SSL sounds like a bad default. It should be explicitly turned off or give errors/ warnings when failing to find certificates.
The text was updated successfully, but these errors were encountered: