Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby support #4

Closed
rurounijones opened this issue Nov 25, 2013 · 6 comments
Closed

JRuby support #4

rurounijones opened this issue Nov 25, 2013 · 6 comments

Comments

@rurounijones
Copy link

Issue #2 kind of got side-tracked with rubinius and jruby so I am opening new issue instead.

The current jruby branch uses jdbc-postgres and activerecord-jdbcpostgresql-adapter but from what I can see it looks like it would be easier to use https://github.com/headius/jruby-pg

Which is aimed to be a "Drop-in" replacement for CRuby's pg driver.

Using that gem might heavily reduce the amount of code modifications required to support jruby. (It is currently marked as an rc level gem)

@BukhariH
Copy link
Contributor

The problem is that this library will be used in a production environment however jruby-pg is not yet ready to be at the stage of production ready because as it isn't passing all the the PG Gem tests.

However, jdbc-postgres is the official driver from postgres and activerecord-jdbc-adapter is production ready as it's passing all of the PG gems tests and it is made and maintained by the team that work on jruby!

However, if a user adds jruby-pg on their gemfile then que should work (though it might be buggy).

@rurounijones
Copy link
Author

Yep, just offering it as an option since there seemed to be issues getting the other gems working.

On a sidenote: The jruby-pg gem is being written in part by Charles Nutter who is on of the Big Kahunas of JRuby.

@BukhariH
Copy link
Contributor

Oh nice! I didn't know that!

jruby-pg is definitely a step in the right direction thats for sure!

@chanks
Copy link
Collaborator

chanks commented Nov 30, 2013

Thanks for pointing me to this gem, I'm looking into it right now. Most of the specs are passing with it, and I think it'll work well.

@chanks
Copy link
Collaborator

chanks commented Nov 30, 2013

Well, most of the specs pass with the gem, but it seems to be currently incompatible with ActiveRecord (since it explicitly checks for the presence of the pg gem), and I'm not sure how to get around that - I guess it'll become a non-issue when jruby-pg becomes the java version of the actual pg gem. But it works for Sequel and the other adapters, and there don't seem to be any compatibility problems aside from the gem thing, so I'm ready to call JRuby officially supported. Thanks again!

@chanks chanks closed this as completed Nov 30, 2013
@rurounijones
Copy link
Author

Congrats! and thanks for supporting the JRuby users 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants