Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Maximum call stack size exceeded #980

Closed
namjul opened this issue Oct 31, 2023 · 1 comment
Closed

Error: Maximum call stack size exceeded #980

namjul opened this issue Oct 31, 2023 · 1 comment

Comments

@namjul
Copy link

namjul commented Oct 31, 2023

🐛 Bug report

I believe this is related to lukeed/klona#44 which suggests that circular dependencies are somehow created. Maybe through using vue@2.7 composition API.

💥 Steps to reproduce

I encounted this while using zag-js with vue@2.7 (using its composition API) and implementing zag-js/combobox.

💻 Link to reproduction

CodeSandbox reproduction: https://codesandbox.io/s/nice-wind-pty88z

🧐 Expected behavior

🧭 Possible Solution

A quick test suggests that using klona/json works as meant to be done here a043048 but the main code now uses klona/full

🌍 System information

Software Version(s)
Zag Version 0.27.0
Browser 118.0.5993.88 (
Operating System Ubuntu@22.04

📝 Additional information

@segunadebayo
Copy link
Member

Hi @namjul,

I can't seem to reproduce this in Vite + Vue. I recommend using Vite or Nuxt when building components.

Here's a working example without the maximum call stack issue:
https://stackblitz.com/edit/vitejs-vite-avmvjf?file=src%2Fcomponents%2FSelect.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants