Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm: LowerWasmArrayBoundsCheck return value #4751

Open
Cellule opened this issue Feb 28, 2018 · 0 comments
Open

Wasm: LowerWasmArrayBoundsCheck return value #4751

Cellule opened this issue Feb 28, 2018 · 0 comments
Labels
Codebase Quality WebAssembly

Comments

@Cellule
Copy link
Contributor

Cellule commented Feb 28, 2018

I think it is possible to remove the return value from Lower*::LowerWasmArrayBoundsCheck.
We are basically adding all the checks above instr and the returned label is not needed and confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Codebase Quality WebAssembly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cellule