Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of SRCINFO->moduleID for ES6 moduleId may not be appropriate #2931

Open
suwc opened this issue May 8, 2017 · 0 comments
Open

Usage of SRCINFO->moduleID for ES6 moduleId may not be appropriate #2931

suwc opened this issue May 8, 2017 · 0 comments
Labels
Codebase Quality Task

Comments

@suwc
Copy link

suwc commented May 8, 2017

Currently storing ES6 moduleId in SRCINFO->moduleID.
For example, in SourceTextModuleRecord::ParseSource():

                this->parser = (Parser*)AllocatorNew(ArenaAllocator, allocator, Parser, scriptContext);
                srcInfo->moduleID = moduleId;

This may not be appropriate and needs investigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Codebase Quality Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dilijev @suwc