Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the baked in repos. #638

Closed
vaikas opened this issue Aug 29, 2023 · 4 comments
Closed

Question about the baked in repos. #638

vaikas opened this issue Aug 29, 2023 · 4 comments

Comments

@vaikas
Copy link
Member

vaikas commented Aug 29, 2023

Would it be bad...

Currently when you run melange convert python, it adds the wolfi repos by default, here:
https://github.com/chainguard-dev/melange/blob/main/pkg/convert/python/python.go#L269

I think it would be nice to be able to pass a flag that those do not get added. Was thinking of just adding a flag --no-wolfi-repo (or something like that) and then a conditional right around the line above.

Context is to try to reduce manual mucking about after a file gets converted, and removing these for wolfi-dev/os repos is usually something that one always does manually. But maybe this assumption is wrong?

@kaniini
Copy link
Contributor

kaniini commented Aug 29, 2023

I think any wolfi-specific behavior should be encoded in wolfictl, not melange.

@vaikas
Copy link
Member Author

vaikas commented Aug 29, 2023

ok, but as a babystep:

  • Remove the hardcodes above (this also applies to things like gem, maybe others)
  • Add them as 'additional-repos' and 'additional-keyrings' in the "calling functions"
  • Add flag to not do ☝️ to keep the existing behaviour as is

Then fix the other users to pass them in explicitly? WDYT?

@kaniini
Copy link
Contributor

kaniini commented Aug 29, 2023

Yep, exactly, sounds good to me.

@vaikas
Copy link
Member Author

vaikas commented Aug 31, 2023

This has been done.

@vaikas vaikas closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants