[SC-1946] Move back to ethabi master

[morelazers]

Description

We are currently using a custom fork of https://github.com/rust-ethereum/ethabi/ which has no-std compatibility.

rust-ethereum/ethabi#236 Seems to have sorted out the no-std issue we were having so we should test this out and move back to it.

[dandanlen]

FWIW there are some other custom additions to our ethabi lib (which also might now be fixed in the main repo, tbc).

From memory - it was related to some dependency resolution issues / turning serialization on/off for ethereum primitives in dependent libs.

A quick win might be to merge the latest version of ethabi into our fork thereof...

[morelazers]

I can give this a crack at some point, should I treat successful compilation as a victory?

[morelazers]

A quick win might be to merge the latest version of ethabi into our fork thereof...

Easier said than done I think: chainflip-io/ethabi#2

[dandanlen]

Surprised to see so many conflicts... our changes were quite localised...

I can give this a crack at some point, should I treat successful compilation as a victory?

Yes I think so.

[morelazers]

I might have used git wrong tbf, I did everything through github.com

[dandanlen]

Fyi. we forked off another fork (darwinia-network).

And our backend repo references a specific branch of our ethabi repo (https://github.com/chainflip-io/ethabi/tree/feature/with-ethereum-serialize).

[morelazers]

Tried to open the correct PR here: chainflip-io/ethabi#3

[dandanlen]

Looking at it again - we already are up-to-date with darwinia-main on the main branch of our own ethabi repo. So we have already done some of the legwork.

I think the right thing to do is simply to merge the feature branch into main in our ethabi repo (there are conflicts tho). I can take a look on Monday.

[dandanlen]

Update: the change has been merged into ethabi master - should be part of the next release.

[morelazers]

Looks like they have a v17.0.0 commit - it's not on their "releases" page yet though.

[dandanlen]

It's on crates.io, so we should be able to reference it from cargo.

I'll take another look.

[dandanlen]

No longer relevant as of #1650