Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add support for Navigation Button API (fixes #90 #92) #93

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Fix: Add support for Navigation Button API (fixes #90 #92) #93

merged 6 commits into from
Jul 10, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 27, 2023 •
edited
Loading

Fixes #90 #92

Fix

Related to #90

  • Integration with Navigation Button API which allows for custom nav button labels
  • Switch nav button template to JSX
  • Update example.json

Related to #92

  • Prefix .visua11y-btn class with .nav__ e.g .nav__visua11y-btn
  • Apply aria-hidden="true" to the .icon
  • Replace the tooltip with <button> level aria-label.

Testing

Add config to course.json:

"_extensions": {
  "_visua11y": {
    "_navOrder": 100,
    "navLabel": "Accessibility",
    "_navTooltip": {
      "_isEnabled": true,
      "text": "Visual accessibility settings"
    }
  }
}

@swashbuck swashbuck self-assigned this Jun 27, 2023
@swashbuck swashbuck mentioned this pull request Jun 27, 2023
Closed
@swashbuck swashbuck changed the title Fix: Add support for Navigation Button API (fixes #90) Fix: Add support for Navigation Button API (fixes #90 #92) Jun 27, 2023
kirsty-hames
kirsty-hames reviewed Jun 28, 2023
View reviewed changes
templates/Visua11yNavigationButton.jsx Outdated
_iconClasses
} = props;
return (
<React.Fragment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the shorthand tag <> work here?

@swashbuck swashbuck marked this pull request as ready for review June 28, 2023 16:26
kirsty-hames
kirsty-hames approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swashbuck, can confirm #90 & #92 fixed. Tested on Mac Safari, FF, Chrome and iPhone.

@swashbuck
Copy link
Contributor Author

Thanks, @kirsty-hames .

@oliverfoster Do you see anything that needs to be changed? I poached most of the code from adaptlearning/adapt-contrib-pageLevelProgress#174

@oliverfoster oliverfoster merged commit 76dbed7 into master Jul 10, 2023
@oliverfoster oliverfoster deleted the issue/90 branch July 10, 2023 16:05
github-actions bot pushed a commit that referenced this pull request Jul 10, 2023
@semantic-release-bot
Chore(release): 2.4.1 [skip ci]
ff7d3a9 
## [2.4.1](v2.4.0...v2.4.1) (2023-07-10)

### Fix

* Add support for Navigation Button API (fixes #90 #92) (#93) ([76dbed7](76dbed7)), closes [#90](#90) [#92](#92) [#93](#93)
@github-actions
Copy link

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swashbuck swashbuck mentioned this pull request Jul 20, 2023
Merged
This was referenced Mar 13, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Navigation Button API
3 participants
@swashbuck @kirsty-hames @oliverfoster