Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove !important from font family #118

Open
swashbuck opened this issue Dec 11, 2024 · 2 comments
Open

Remove !important from font family #118

swashbuck opened this issue Dec 11, 2024 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Dec 11, 2024

Is it necessary to use !important here to set the font family? There are times when we need to change the nav icon, and it then requires another !important on top of the existing one. This can lead to styles being difficult to maintain.

font-family: '@{icomoon-font-family}' !important;

Example of changing the default nav icon:
Screenshot 2024-12-11 at 1 04 57 PM

@swashbuck swashbuck added enhancement New feature or request question Further information is requested labels Dec 11, 2024
@oliverfoster
Copy link
Member

Have you tried doing the thing it says as the reason for the ! important in the comment on the line before?

/* use !important to prevent issues with browser extensions that change fonts */

Like:
https://chromewebstore.google.com/detail/cubility-the-accessibilit/hldpmlpccijbfgdplddoldjehkeialfk?hl=en&pli=1
https://dyslexiefont.com/en/chrome-extension/

@swashbuck
Copy link
Contributor Author

Have you tried doing the thing it says as the reason for the ! important in the comment on the line before?

Wouldn't this be an issue with all Vanilla font icons, not just the icon in the Visua11y nav button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants