Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a layer from WorldMap has the potential to leave cruft behind in Dataverse (and a bad user experience) #214

Closed
pdurbin opened this issue Mar 24, 2017 · 6 comments

Comments

@pdurbin
Copy link

pdurbin commented Mar 24, 2017

IQSS/dataverse#3480 (comment) has some screenshots I just took. It would be nice if WorldMap said something like "this layer is in use by a dataset with a published DOI" or something. This is what the sees in WorldMap when deleting a map that has an association with a dataset in Dataverse:

screen shot 2017-03-24 at 9 49 54 am

@raprasad
Copy link

fyi: Due to the WorldMap upgrade process/schedule, this likely won't be added until 2018. e.g. Any functionality added now has to be re-written post WorldMap migraton to the new geonode

@pdurbin
Copy link
Author

pdurbin commented Apr 11, 2017

We merged IQSS/dataverse#3721 to fix the bad user experience on the Dataverse side described at IQSS/dataverse#3480. I still think it would be nice if WorldMap users got a warning that the map they're deleting has an association with a published dataset but please feel free to close this if you disagree.

@capooti
Copy link

capooti commented Apr 11, 2017

@pdurbin removing a map does not remove the layers contained in it.
With respect of removing a layer associated with a published dataset in Dataverse I am open: @bglewis what is your opinion about it?

@blewis
Copy link

blewis commented Apr 11, 2017

Wouldn't this only hold for user = Dataverse which should know better? That isn't to say it would be useless but would argue for doing it later when we only need to implement once.

@pdurbin
Copy link
Author

pdurbin commented Apr 11, 2017

Later is fine. Or not at all. 😄

Sorry if I'm confusing "map" vs "layer" again. I think in the screenshot above it was a "layer" that I was deleting.

As far as I understand, Dataverse users are not creating their own WorldMap accounts. Rather, shared credentials are stored in Geoconnect and all layers are created by that WorldMap account (username "dataverse_user" according to IQSS/dataverse#3495 (comment) ). End users shouldn't have the password so it should be rare that a layer is deleted directly from the WorldMap interface, which is what this issue is about. Again, please feel free to close this if it's hard to warn the user or if it's not worth doing because it's such an edge case.

@capooti
Copy link

capooti commented Apr 12, 2017

OK, I am closing it, we can re-open if there is the need.

@capooti capooti closed this as completed Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants