Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to the newly added XML schema file #481

Closed
larsbarring opened this issue Apr 18, 2024 · 2 comments · Fixed by #482
Closed

Minor update to the newly added XML schema file #481

larsbarring opened this issue Apr 18, 2024 · 2 comments · Fixed by #482
Labels
defect Content mistake on the website

Comments

@larsbarring
Copy link
Contributor

larsbarring commented Apr 18, 2024

There is a schema mismatch between the new XML element for the "first published date" in the XML file. The element was introduced in cf-conventions/#511 as first_published, but was in the schema file written as first_published_date. The "_date" part is quite unnecessary and even not correct as the information carried by this element is in fact an xml dateTime object.

See PR #482

@larsbarring
Copy link
Contributor Author

Hi Sadie @sadielbartholomew: May I one last time ask you: this time to merge this PR #482, which is correcting a minor oversight on my part. After closing this, and #516 everything the set to dig into #470 that will keep me busy for a while :-))

Many thanks,
Lars

@sadielbartholomew
Copy link
Member

Good spot Lars. Sure, I will review it and merge if good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Content mistake on the website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants