Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Idea: Create MurmurHash comparison strategy #74

Closed
lukasz-pekala opened this issue Nov 9, 2020 · 2 comments
Closed

Idea: Create MurmurHash comparison strategy #74

lukasz-pekala opened this issue Nov 9, 2020 · 2 comments

Comments

@lukasz-pekala
Copy link
Contributor

This seems to be quicker (still probably slower than counting pixels :) ) than MD5 and widely adopted (e.g. Elasticsearch):
https://stackoverflow.com/questions/3665247/fastest-hash-for-non-cryptographic-uses

New projects could use it. For existing projects this would require 'marking as pattern' or some kind of a migration tool.
We can now implement strategies side-by-side with HashComparisonStrategy (this would need to be renamed to MD5HashComparisonStrategy) and PixelByPixelComparisonStrategy

@lukasz-pekala
Copy link
Contributor Author

lukasz-pekala commented Nov 9, 2020

Seems there's even something faster:
https://github.com/Cyan4973/xxHash
https://github.com/noricube/xxHashSharp (not updated project though...)

@lukasz-pekala
Copy link
Contributor Author

Counting pixels turned out to be the fastest. Hashes are not needed for our tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant