Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Error: global: Additional property is not allowed: prevents installation as a sub-chart and on Rancher RKE #7329

Closed
AreYouLoco opened this issue Oct 3, 2024 · 9 comments · Fixed by cert-manager/helm-tool#42 or #7346
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@AreYouLoco
Copy link

AreYouLoco commented Oct 3, 2024

📢 cert-manager v1.16.1 has the fix for this bug.

Describe the bug:
After trying to upgrade from v1.15.3 to v1.16.0 I encountered an issue. I believe its related to using RKE1 self-hosted as kubernetes engine. There is no way for me to delete the conflicting property "cattle" because it gets added automatically by Rancher Kubernetes Engine

root@rke-master:~# helm upgrade cert-manager jetstack/cert-manager --namespace cert-manager
Error: UPGRADE FAILED: values don't meet the specifications of the schema(s) in the
 following chart(s):
cert-manager:
- global: Additional property cattle is not allowed

Expected behaviour:
Deployment will pull the new image and successfully upgrade. I've read the breaking changes and I believe its because of new validation of the fields in values.yml

Steps to reproduce the bug:
First I've tried to upgrade from Rancher webui but the result is the same when using helm directly. Command and output above. To note I've made sure to apply CRDs before upgrade and that went well. No issues.

Anything else we need to know?:
The conflicting property from values.yml is the following:

global:
  cattle:
    systemProjectId: some-short-unique-value

I guess this property should be taken into account and/or getting whitelisted to solve the issue.

Environment details::

  • Kubernetes version: v1.30.4
  • Cloud-provider/provisioner: RKE1
  • cert-manager version: v1.15.3 to v1.16.0
  • Install method:
    Rancher webui and helm upgrade

/kind bug

@cert-manager-prow cert-manager-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2024
@AreYouLoco
Copy link
Author

Seems I managed to fix it by adding

--reset-values

to helm upgrade command. But I guess the problem might be back with next release. I cannot recall if I had something special in values.yml when initially deploying.

This should be in release notes that there might be a problem on RKE1.

@lemniskett
Copy link

Second this.

@roderik
Copy link

roderik commented Oct 4, 2024

Same here with enabled: true

I install cert-manager as a subchart:

cert-manager:
  enabled: false
  ...

The latest version sets "additionalProperties": false, in the json schema and cert-manager does not know about enabled or in the OP's issue cattle. A similar issue in another chart open-telemetry/opentelemetry-helm-charts#228

@wallrj
Copy link
Member

wallrj commented Oct 4, 2024

Thanks for reporting the issue. We'll investigate further.

@wallrj wallrj changed the title cert-manager: - global: Additional property cattle is not allowed when trying to upgrade from 1.15.3 to 1.16.0 Helm: Error: global: Additional property is not allowed: prevents installation as a sub-chart and on Rancher RKE Oct 4, 2024
@wallrj
Copy link
Member

wallrj commented Oct 4, 2024

Linked to this known issue in the 1.16.0 release page.

@wallrj
Copy link
Member

wallrj commented Oct 4, 2024

/milestone 1.16

@wallrj
Copy link
Member

wallrj commented Oct 9, 2024

📢 cert-manager v1.16.1 has the fix for this bug.

@AreYouLoco
Copy link
Author

Thanks! The helm chart is not available yet. I will check it out when its there. CRDs already applied

@AreYouLoco
Copy link
Author

I confirm that I upgraded without --reset-values and it went fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
4 participants