Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apple Silicon Support #12

Closed
cerpow opened this issue Jun 15, 2021 · 7 comments
Closed

Add Apple Silicon Support #12

cerpow opened this issue Jun 15, 2021 · 7 comments

Comments

@cerpow
Copy link
Owner

cerpow commented Jun 15, 2021

Support for M1 powered macs
@MrKai77
Copy link
Contributor

MrKai77 commented Nov 11, 2022 •
edited
Loading

I tried building this app with this comment and successfully built x64, arm64, and universal binaries. Might be worth adding the universal option into package.json!

@cerpow
Copy link
Owner Author

cerpow commented Nov 11, 2022

Hey @MrKai77 ,
That is awesome! Do you have an Apple Silicon mac to test if it works?

@MrKai77
Copy link
Contributor

MrKai77 commented Nov 11, 2022 •
edited
Loading

Yes! The arm64 binary works exactly like the x64 version!

@cerpow
Copy link
Owner Author

cerpow commented Nov 11, 2022

Nice! Can you a pull request and i upload the arm64 version to releases. But We still need to fix the update checker to download the correct file. Tanks for trying it out!

@cerpow
Copy link
Owner Author

cerpow commented Nov 11, 2022

Can you also look and test that? I still don't have an arm64 mac :( Much appreciated! @MrKai77

@cerpow
Copy link
Owner Author

cerpow commented Nov 12, 2022 •
edited
Loading

@MrKai77 I fixed the updater btw and built new dmg files.

@cerpow cerpow closed this as completed Nov 12, 2022
@MrKai77
Copy link
Contributor

MrKai77 commented Nov 12, 2022

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cerpow @MrKai77