Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support block volume #132

Merged
merged 6 commits into from
Jan 17, 2019
Merged

support block volume #132

merged 6 commits into from
Jan 17, 2019

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Jan 16, 2019

this is cherry picked from #97, removing csi v1 commits

@rootfs
Copy link
Member Author

rootfs commented Jan 16, 2019

ping @mkimuram

mkimuram and others added 2 commits January 16, 2019 13:00
@mkimuram
Copy link
Contributor

@rootfs

Thank you for your help in making block-volume-feature PR progress.
It looks good except that there are three lines missing in csi-rbdplugin.yaml.
After adding them, it worked properly in my environment.

# diff -urN csi-rbdplugin.yaml.orig csi-rbdplugin.yaml
--- csi-rbdplugin.yaml.orig     2019-01-16 20:12:59.877833851 +0000
+++ csi-rbdplugin.yaml  2019-01-16 20:21:36.182023115 +0000
@@ -69,6 +69,9 @@
           volumeMounts:
             - name: plugin-dir
               mountPath: /var/lib/kubelet/plugins_registry/csi-rbdplugin
+            - name: plugin-mount-dir
+              mountPath: /var/lib/kubelet/plugins/kubernetes.io/csi/volumeDevices/
+              mountPropagation: "Bidirectional"
             - name: pods-mount-dir
               mountPath: /var/lib/kubelet/pods
               mountPropagation: "Bidirectional"

@rootfs
Copy link
Member Author

rootfs commented Jan 17, 2019

thanks @mkimuram

Signed-off-by: Huamin Chen <hchen@redhat.com>
@rootfs rootfs changed the title [WIP] support block volume support block volume Jan 17, 2019
@rootfs rootfs merged commit af00847 into ceph:csi-v1.0 Jan 17, 2019
@rootfs
Copy link
Member Author

rootfs commented Jan 17, 2019

Tested on k8s 1.13.2 with CSIBlockVolume gate enabled.

wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants