Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade, the resize capability is not working for the existing PV/PVC #935

Closed
yanchicago opened this issue Apr 13, 2020 · 2 comments
Closed
Labels
bug Something isn't working component/deployment Helm chart, kubernetes templates and configuration Issues/PRs dependency/k8s depends on Kubernetes features

Comments

@yanchicago
Copy link

yanchicago commented Apr 13, 2020

Describe the bug

A clear and concise description of what the bug is.
After upgrade to ceph-csi 2.0.1, the resize feature only applies to a new PVC not the existing PVC.

Environment details

  • Image/version of Ceph CSI driver: cephcsi:v2.0.1, csi-resizer:v0.4.0
  • helm chart version
  • Kubernetes cluster version: v1.16.4
  • Logs

Steps to reproduce

Steps to reproduce the behavior:

  1. Setup details: '...'
  2. Deployment to trigger the issue '....'
  3. See error

Note: It could be an enhancement?

1). Deployed rook ceph 1.1.7
2). Upgrade rook ceph cluster to 1.2.7
3). Force replace the existing storage class with additional parameters: "allowVolumeExpansion: true
" and "csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner".
4). Try "resize" an existing PVC of a statefulset, the operation failed with below error in csi-resizer pod.
Note: For the newly created PVC

I0413 18:03:23.398029       1 event.go:281] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"rook-ceph", Name:"my-block-testrookblk-0", UID:"6c444e06-1442-4018-bc45-30f39cc9e1a5", APIVersion:"v1", ResourceVersion:"76782351", FieldPath:""}): type: 'Warning' reason: 'VolumeResizeFailed' resize volume pvc-6c444e06-1442-4018-bc45-30f39cc9e1a5 failed: rpc error: code = Internal desc = provided secret is empty

Actual results

Describe what happened
The size of PVC stays as the same.

Expected behavior

A clear and concise description of what you expected to happen.
The size of PVC should be changed to the requested size provided by "resize"

Additional context

Add any other context about the problem here.

For example:

Any existing bug report which describe about the similar issue/behavior
There're two existing similar problems.
#783
#923

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 14, 2020

I already created a kubernetes issue for the same kubernetes/kubernetes#88622

@nixpanic nixpanic added this to the release-2.0.2 milestone Apr 17, 2020
@nixpanic nixpanic added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Apr 17, 2020
@nixpanic nixpanic removed this from the release-2.0.2 milestone Apr 17, 2020
@nixpanic nixpanic added bug Something isn't working dependency/k8s depends on Kubernetes features labels Apr 17, 2020
@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 20, 2020

This is not something can be done in cephcsi directly, this has to be fixed in kubernetes closing this one

@Madhu-1 Madhu-1 closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/deployment Helm chart, kubernetes templates and configuration Issues/PRs dependency/k8s depends on Kubernetes features
Projects
None yet
Development

No branches or pull requests

3 participants