-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's Encrypt SSL Certificates #133
Comments
Hello! Yeah, why not, I'll look at this soon. Thanks for suggestion |
Hi, awesome! Thank you! |
@ramon-ga just added code into {
...
"ssl_autocert": true,
"ssl_autocert_host_whitelist": "www.example.com",
"ssl_autocert_cache_dir": "/tmp/certs",
"ssl_autocert_email": "user@example.com"
} Email is optional, Could you test it with real domain? |
Hi, wow you're very fast! I had some time set it up on a test server and can confirm it's working! Thank you very much for your work! Some Details about the test: Server: Ubuntu 16.04 / go version go1.6.2 linux/amd64 Build centrifugo:
Config updated with:
|
Great, thanks for testing! Then it will be part of v1.6.1 - I think I'll release it very soon as there are several small fixes already in master. |
Great! As soon as the release is done, i'm setup it up on the production server. |
v1.6.1 released |
Will Let's Encrypt automatic certificates renew when they are about to expire? |
@manson yes, they should (1 week before expiration) |
Not sure where 1 week came from - is that the default for the client lib you used?
All the clients I've seen renew with a month to go so they renew every 2 months.
I don't think it's a big deal but one reason it might be worth increasing the time in a future release: I've seen lets encrypt rate limits kick in which are reasonably generous but not that hard to hit if you are systematically generating SSL certs (in our case we hit them despite negotiating an increase over the default limit partly due to a bug on their side, and despite this relationship, their engineers were unable to lift the block early and we had to wait a week...). When they do you are effectively blocked for a week from any new certificates being generated or renewed (actually I'm not sure about the renewed part but IIRC renewal is the same API call as initial generation anyway so I guess it's true).
… On 3 Jan 2017, at 04:49, Alexandr Emelin ***@***.***> wrote:
@manson yes, they should (1 week before expiration)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@banks here it is, looking in their limit docs it seems that renew requests does not count rate limit and they have 1 week sliding window for limits. So we have to be very unlucky to hit the limit. Let's make it 2 weeks to remove that probability? |
Should it be What have I missed? |
@manson it already works with valid HTTPS certificates (you can make sure trying to send request to our demo instance: We also can add |
could you tell which fonts? |
@FZambia Thats great you have no problem connecting I've checked links you supplied. Both are related to switching off security so I dont get it what in this case is ssl, sertificates and so on for? Or I dont get something?
as for fonts. This what I see in browser console when opening centrifugo admin UI: bundle.js:2121Mixed Content: The page at 'https://mysite:8000/#/' was loaded over HTTPS, but requested an insecure font 'http://themes.googleusercontent.com/static/fonts/inconsolata/v5/BjAYBlHtW3CJxDcjzrnZCIbN6UDyHWBl620a-IRfuBk.woff'. This request has been blocked; the content must be served over HTTPS.` |
@manson this is our public demo: it's secret key is More specifically about SO answer: could you try to inject CA certificates using About port: I have never done it myself, but see this - so maybe you have to run Centrifugo on standard 443 port and the problem will go away? So please try options above. I think it's worth adding Thanks for font warning: this is a bit strange - we have not use any of those fonts explicitly - i.e. I grepped over files and have not found them.. Also I have no such warning on our https instances. Maybe they are coming from one of browser extensions (in Chrome you can try to load a page in incognito mode as most extensions disabled in that mode)? |
@FZambia Ok. I managed to connect to your instance with secret key. At least now I had no exceptions on my serverside code. Although my browser client right after connection gets disconnected, I assume it ok at least for this issue. Will try with ports playing but if this is the case its not very well bc I plan to use the webserver ssl processing. I.e. 433 port will be my webserver port, so they may conflict... I'm getting into a mess with all this. Separatelly I understand how it should work but not in common, under the one server roof.
|
@FZambia Excuse me, I have another question but dont know where to ask it. Its not an issue just a question. Why dont you want to do a serverside subscription? I mean in For updated |
@manson it's theoretically possible and maybe it's possible to adapt our browser client to work server-side too - but I just have no resources to develop and support clients for all backend languages. There is already a way to do some callback action just calling it from client (browser) side via AJAX call for example. Btw you can ask questions in our chat on Gitter - https://gitter.im/centrifugal/centrifugo |
@FZambia I see. Thank you! Centrifugo is a great tool! :-) |
Maybe it's possible to integrate the following to get automatically ssl certificates from Let's Encrypt.
Resources:
https://godoc.org/golang.org/x/crypto
https://godoc.org/golang.org/x/crypto/acme/autocert
Sample Integration Diff (Not tested):
I'm using this already in a other go server and it's working.
The text was updated successfully, but these errors were encountered: