Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vmware8-esx): new plugin to monitor ESX status using vSphere 8 API #5264

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

omercier
Copy link
Contributor

Description

feat(vmware8-esx): new plugin to monitor ESX status using vSphere 8 API

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier force-pushed the CTOR-478-VMWare-8-MVP-modes-Pack-ESX-foundations branch 5 times, most recently from 2632406 to 9ae7002 Compare October 28, 2024 16:20
@omercier omercier marked this pull request as ready for review October 29, 2024 07:39
@omercier omercier requested review from a team as code owners October 29, 2024 07:39
src/apps/vmware/vsphere8/custom/api.pm Outdated Show resolved Hide resolved
src/apps/vmware/vsphere8/custom/api.pm Outdated Show resolved Hide resolved
src/apps/vmware/vsphere8/custom/api.pm Show resolved Hide resolved
src/centreon/plugins/misc.pm Outdated Show resolved Hide resolved
src/centreon/plugins/misc.pm Show resolved Hide resolved
src/centreon/plugins/statefile.pm Outdated Show resolved Hide resolved
src/centreon/plugins/statefile.pm Outdated Show resolved Hide resolved
src/centreon/plugins/statefile.pm Outdated Show resolved Hide resolved
tests/centreon/plugins/statefile.t Outdated Show resolved Hide resolved
@omercier omercier force-pushed the CTOR-478-VMWare-8-MVP-modes-Pack-ESX-foundations branch from 749e1c3 to b221cc3 Compare October 29, 2024 14:44
@omercier omercier requested a review from Evan-Adam October 31, 2024 16:48
Evan-Adam
Evan-Adam previously approved these changes Nov 4, 2024
sdepassio
sdepassio previously approved these changes Nov 8, 2024
omercier and others added 2 commits November 8, 2024 11:35
Co-authored-by: sdepassio <114986849+sdepassio@users.noreply.github.com>
@omercier omercier force-pushed the CTOR-478-VMWare-8-MVP-modes-Pack-ESX-foundations branch from 63a93bf to 1250b1e Compare November 8, 2024 10:36
@omercier omercier merged commit 63b3054 into develop Nov 8, 2024
23 checks passed
@omercier omercier deleted the CTOR-478-VMWare-8-MVP-modes-Pack-ESX-foundations branch November 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants