From 6e275a706830ab46b15b951cea1de7168a4a7956 Mon Sep 17 00:00:00 2001
From: jeremyjaouen <61694165+jeremyjaouen@users.noreply.github.com>
Date: Thu, 28 Jul 2022 08:04:47 +0200
Subject: [PATCH] fix(hostgroup): fix display of hostgroups in select2 (#11431)

---
 www/class/centreonHostgroups.class.php | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/www/class/centreonHostgroups.class.php b/www/class/centreonHostgroups.class.php
index c8c5b1225a2..34dd68d6947 100644
--- a/www/class/centreonHostgroups.class.php
+++ b/www/class/centreonHostgroups.class.php
@@ -334,6 +334,12 @@ public function getObjectForSelect2($values = array(), $options = array())
             return $items;
         }
 
+        $hostgroups = [];
+        // $values structure: ['1,2,3,4'], keeping the foreach in case it could have more than one index
+        foreach ($values as $value) {
+            $hostgroups = array_merge($hostgroups, explode(',', $value));
+        }
+
         // get list of authorized hostgroups
         if (!$centreon->user->access->admin) {
             $hgAcl = $centreon->user->access->getHostGroupAclConf(
@@ -347,7 +353,7 @@ public function getObjectForSelect2($values = array(), $options = array())
                     'conditions' => array(
                         'hostgroup.hg_id' => array(
                             'IN',
-                            $values
+                            $hostgroups
                         )
                     )
                 ),
@@ -359,15 +365,13 @@ public function getObjectForSelect2($values = array(), $options = array())
         $listValues = '';
         $queryValues = array();
 
-        foreach ($values as $k => $v) {
-            //As it happens that $v could be like "X,Y" when two hostgroups are selected, we added a second foreach
-            $multiValues = explode(',', $v);
-            foreach ($multiValues as $item) {
-                $ids = explode('-', $item);
-                $listValues .= ':hgId_' . $ids[0] . ', ';
-                $queryValues['hgId_' . $ids[0]] = (int)$ids[0];
-            }
+        foreach ($hostgroups as $item) {
+            // the below explode may not be useful
+            $ids = explode('-', $item);
+            $listValues .= ':hgId_' . $ids[0] . ', ';
+            $queryValues['hgId_' . $ids[0]] = (int)$ids[0];
         }
+
         $listValues = rtrim($listValues, ', ');
         $query = 'SELECT hg_id, hg_name FROM hostgroup WHERE hg_id IN (' . $listValues . ') ORDER BY hg_name ';
         $stmt = $this->DB->prepare($query);