From 7b0e505bab97dc10e6747d64c884a38662d35a0f Mon Sep 17 00:00:00 2001
From: Elmahdi ABBASSI <108519266+emabassi-ext@users.noreply.github.com>
Date: Mon, 18 Jul 2022 10:53:59 +0100
Subject: [PATCH] [SNYK] Sanitize and bind ACL host dependency queries (#11389)

* Sanitize and bind ACL host dependency queries

* fix issues
---
 .../configObject/host_dependency/DB-Func.php  | 27 ++++++++++++-------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/www/include/configuration/configObject/host_dependency/DB-Func.php b/www/include/configuration/configObject/host_dependency/DB-Func.php
index ed2f2da78fc..1a7733003ef 100644
--- a/www/include/configuration/configObject/host_dependency/DB-Func.php
+++ b/www/include/configuration/configObject/host_dependency/DB-Func.php
@@ -123,11 +123,14 @@ function multipleHostDependencyInDB($dependencies = array(), $nbrDup = array())
                         "WHERE dependency_dep_id = " . $key;
                     $dbResult = $pearDB->query($query);
                     $fields["dep_serviceChilds"] = "";
+                    $statement = $pearDB->prepare("INSERT INTO dependency_serviceChild_relation " .
+                        " VALUES (:max_dep_id, :service_id, :host_host_id)");
                     while ($service = $dbResult->fetch()) {
-                        $query = "INSERT INTO dependency_serviceChild_relation VALUES ('" .
-                            $maxId["MAX(dep_id)"] . "', '" . $service["service_service_id"] . "', '" .
-                            $service["host_host_id"] . "')";
-                        $pearDB->query($query);
+                        $statement->bindValue(':max_dep_id', (int)$maxId["MAX(dep_id)"], \PDO::PARAM_INT);
+                        $statement->bindValue(':service_id', (int)$service["service_service_id"], \PDO::PARAM_INT);
+                        $statement->bindValue(':host_host_id', (int)$service["host_host_id"], \PDO::PARAM_INT);
+                        $statement->execute();
+
                         $fields["dep_serviceChilds"] .= $service["host_host_id"] .
                             '-' . $service["service_service_id"] . ",";
                     }
@@ -136,10 +139,12 @@ function multipleHostDependencyInDB($dependencies = array(), $nbrDup = array())
                         "WHERE dependency_dep_id = '" . $key . "'";
                     $dbResult = $pearDB->query($query);
                     $fields["dep_hostParents"] = "";
+                    $statement = $pearDB->prepare("INSERT INTO dependency_hostParent_relation " .
+                        "VALUES (:max_dep_id, :host_host_id)");
                     while ($host = $dbResult->fetch()) {
-                        $query = "INSERT INTO dependency_hostParent_relation " .
-                            "VALUES ('" . $maxId["MAX(dep_id)"] . "', '" . $host["host_host_id"] . "')";
-                        $pearDB->query($query);
+                        $statement->bindValue(':max_dep_id', (int)$maxId["MAX(dep_id)"], \PDO::PARAM_INT);
+                        $statement->bindValue(':host_host_id', (int)$host["host_host_id"], \PDO::PARAM_INT);
+                        $statement->execute();
                         $fields["dep_hostParents"] .= $host["host_host_id"] . ",";
                     }
                     $fields["dep_hostParents"] = trim($fields["dep_hostParents"], ",");
@@ -148,10 +153,12 @@ function multipleHostDependencyInDB($dependencies = array(), $nbrDup = array())
                         "WHERE dependency_dep_id = '" . $key . "'";
                     $dbResult = $pearDB->query($query);
                     $fields["dep_hostChilds"] = "";
+                    $statement = $pearDB->prepare("INSERT INTO dependency_hostChild_relation " .
+                        "VALUES (:max_dep_id, :host_host_id)");
                     while ($host = $dbResult->fetch()) {
-                        $query = "INSERT INTO dependency_hostChild_relation " .
-                            "VALUES ('" . $maxId["MAX(dep_id)"] . "', '" . $host["host_host_id"] . "')";
-                        $pearDB->query($query);
+                        $statement->bindValue(':max_dep_id', (int)$maxId["MAX(dep_id)"], \PDO::PARAM_INT);
+                        $statement->bindValue(':host_host_id', (int)$host["host_host_id"], \PDO::PARAM_INT);
+                        $statement->execute();
                         $fields["dep_hostChilds"] .= $host["host_host_id"] . ",";
                     }
                     $fields["dep_hostChilds"] = trim($fields["dep_hostChilds"], ",");