Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

OpenTracing implementation on top of OpenCensus trace #502

Open
semistrict opened this issue Feb 28, 2018 · 9 comments
Open

OpenTracing implementation on top of OpenCensus trace #502

semistrict opened this issue Feb 28, 2018 · 9 comments

Comments

@semistrict
Copy link
Contributor

Many frameworks have already been instrumented with OpenTracing. Building an OpenTracing implementation on top of OpenCensus would give us compatibility with these frameworks.

@semistrict semistrict added enhancement trace up-for-grabs Good item for new contributors to start working on labels Feb 28, 2018
@savaki
Copy link
Contributor

savaki commented Feb 28, 2018

I've written a few open tracing implementations so I'd be happy to do this. There are a couple of incompatibilities that I'd love some guidance on:

  • OT has a concept of baggage, strings key values that are set on a span and passed to all child spans. I'm assuming we would just document this is not supported.
  • OT has logging integrated. My suggestion here is that the OC OT implementation allow for an optional logger interface to be provided.
  • OT tags are string => interface{} which is much broader than an attribute. Presumably this would be another one to document.

The primary behavior that will be odd for people using the OC OT implementation imho is that log messages which previously contained baggage would now just contain the log message (plus attributes). I know we put things like tenantID and userID into the baggage so losing these would be a showstopper.

@savaki
Copy link
Contributor

savaki commented Feb 28, 2018

If I put my marketing hat on. If you really want OC to be widely adopted, perhaps a parallel approach would be to write native OC implementations for those other frameworks. Otherwise, there's really no reason to use OC directly if you can always use the OT adapter.

@semistrict semistrict removed the up-for-grabs Good item for new contributors to start working on label Mar 5, 2018
@semistrict
Copy link
Contributor Author

We are worried that having two trace recording APIs in this repo will cause confusion for users. We are looking for an appropriate place to put this work.

@savaki
Copy link
Contributor

savaki commented Mar 5, 2018

Fair enough. Let me know what you'd like me to do.

@semistrict
Copy link
Contributor Author

@savaki we are going to create an "opencensus-contrib" organization to put all the integrations (including exporters) and I think this can go there. You can keep the PR open for now if you like or publish it to a repo in your account that we can then clone to the new org once it has been created. It should be created this week.

@someone1
Copy link

Would love to see this (the OpenTracing vs OpenCensus debate is making my head spin) - is there a connector somewhere for this today? I can't seem to find anything anywhere, did the previous work just disappear?

@smartheye
Copy link

hi, happy to see this issue. is there possible that opencensus provide a opentraing api. a bridge. I am using opencensus, you guys are doing great!

@sagikazarmark
Copy link
Contributor

I'm looking for a solution as well. Although it would be great to see OC adoption instead of using bridges, when using third party stuff (eg. Traefik), we don't really have a choice.

@rghetia
Copy link
Contributor

rghetia commented May 6, 2019

This will be addressed in upcoming OC - OT merging. keeping the issue open untill we haver merged api available.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants