Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swamp: Integration tests with celestia-app instead of kvstore #628

Closed
liamsi opened this issue Apr 16, 2022 · 1 comment · Fixed by #1160
Closed

swamp: Integration tests with celestia-app instead of kvstore #628

liamsi opened this issue Apr 16, 2022 · 1 comment · Fixed by #1160
Assignees
Labels
enhancement New feature or request kind:testing Related to unit tests swamp Related to Integration tests

Comments

@liamsi
Copy link
Member

liamsi commented Apr 16, 2022

Implementation ideas

Use the app in swamp tests: #626 (comment)

@liamsi liamsi added enhancement New feature or request kind:testing Related to unit tests swamp Related to Integration tests labels Apr 16, 2022
@renaynay renaynay changed the title Integration tests with celestia-app instead of kvstore swamp: Integration tests with celestia-app instead of kvstore Apr 20, 2022
@evan-forbes evan-forbes self-assigned this Sep 23, 2022
@evan-forbes
Copy link
Member

evan-forbes commented Sep 23, 2022

This will need to change before we can upgrade to v0.7.0 of the app. This is due to the new processing that must occur to block data before it can properly split into shares, along with the complete removal of deprecated share encoding logic in core (ComputeShares).

This could occur via two ways. We started on a solution that would likely require less refactoring of the swamp test, but this functionality is also already implemented in our own integration test suite. The latter might be more useful, since it also does some initialization necessary to generate many different PFDs at once.

I'll try to refactor the swamp test to use the integration test suite that we're already using, but I'm open to a spending more time on the custom solution linked above if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind:testing Related to unit tests swamp Related to Integration tests
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants