Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipld: optionally limit the number of spawned go-rountines in RetrieveBlockData #357

Closed
liamsi opened this issue May 26, 2021 · 1 comment
Closed

ipld: optionally limit the number of spawned go-rountines in RetrieveBlockData #357

liamsi opened this issue May 26, 2021 · 1 comment
Labels
C:ipld Access to the IPLD merkle dag good first issue Good for newcomers T:enhancement Type: Enhancement T:tests

Comments

@liamsi
Copy link
Member

liamsi commented May 26, 2021

Context: #352 (comment)

It would be good if this was somehow configurable.
(In the meantime, if this isn't tackled right away, we shouldn't silently but explicitly skip over larger tests).
@liamsi liamsi added T:enhancement Type: Enhancement T:tests C:ipld Access to the IPLD merkle dag labels May 26, 2021
@liamsi liamsi mentioned this issue May 26, 2021
Merged
@liamsi liamsi changed the title ipld: optionally limit the number of spawned go-rountines in ipld: optionally limit the number of spawned go-rountines in RetrieveBlockData May 26, 2021
@evan-forbes evan-forbes added the good first issue Good for newcomers label May 27, 2021
@liamsi liamsi mentioned this issue May 31, 2021
Closed
@jclyons52 jclyons52 mentioned this issue Jun 19, 2021
Closed
@liamsi
Copy link
Member Author

liamsi commented Aug 16, 2021

The code this issue is about should either be moved into a separate repo or simply be moved into https://github.com/celestiaorg/celestia-node. Hence, closing.

ref: celestiaorg/celestia-node#1

@liamsi liamsi closed this as completed Aug 16, 2021
@Wondertan Wondertan mentioned this issue Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:ipld Access to the IPLD merkle dag good first issue Good for newcomers T:enhancement Type: Enhancement T:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit the number of spawned go-rountines in RetrieveBlockData jclyons52/lazyledger-core
2 participants
@liamsi @evan-forbes