You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As an intermediate step to completing #184, the data availability header was added to the BlockID in #312. Introducing the data availability header dramatically changes the number of bytes in Commits, Votes, and the Block structs, and this fact effects the functions that count the max number of bytes, along with the tests for those functions. Most notably, three tests have been commented out until the BlockID is replaced with the header hash. These tests are TestMaxCommitBytes, TestBlockMaxDataBytes, and TestBlockMaxDataBytesNoEvidence. Not only do these tests have to be uncommented, but the functions that they test need to refactored in order to accomodate for the data availability header when necessary. There should also be an equivalent max byte function/test for the DataAvailabilityHeader.
The text was updated successfully, but these errors were encountered:
evan-forbes
changed the title
Reinstae and refactor the MaxByte functions and tests to accomodate the DataAvailabilityHeader
Refactor the MaxByte functions to accomodate the DataAvailabilityHeaderMay 15, 2021
As an intermediate step to completing #184, the data availability header was added to the
BlockID
in #312. Introducing the data availability header dramatically changes the number of bytes inCommit
s,Vote
s, and theBlock
structs, and this fact effects the functions that count the max number of bytes, along with the tests for those functions. Most notably, three tests have been commented out until theBlockID
is replaced with the header hash. These tests are TestMaxCommitBytes, TestBlockMaxDataBytes, and TestBlockMaxDataBytesNoEvidence. Not only do these tests have to be uncommented, but the functions that they test need to refactored in order to accomodate for the data availability header when necessary. There should also be an equivalent max byte function/test for theDataAvailabilityHeader
.The text was updated successfully, but these errors were encountered: