Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the MaxByte functions to accomodate the DataAvailabilityHeader #335

Closed
evan-forbes opened this issue May 15, 2021 · 1 comment
Closed

Comments

@evan-forbes
Copy link
Member

As an intermediate step to completing #184, the data availability header was added to the BlockID in #312. Introducing the data availability header dramatically changes the number of bytes in Commits, Votes, and the Block structs, and this fact effects the functions that count the max number of bytes, along with the tests for those functions. Most notably, three tests have been commented out until the BlockID is replaced with the header hash. These tests are TestMaxCommitBytes, TestBlockMaxDataBytes, and TestBlockMaxDataBytesNoEvidence. Not only do these tests have to be uncommented, but the functions that they test need to refactored in order to accomodate for the data availability header when necessary. There should also be an equivalent max byte function/test for the DataAvailabilityHeader.

@evan-forbes evan-forbes changed the title Reinstae and refactor the MaxByte functions and tests to accomodate the DataAvailabilityHeader Refactor the MaxByte functions to accomodate the DataAvailabilityHeader May 15, 2021
@evan-forbes
Copy link
Member Author

This DAH is no longer included in the blockID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant