Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially increase share size #732

Closed
Tracked by #650
liamsi opened this issue Aug 6, 2021 · 4 comments
Closed
Tracked by #650

Potentially increase share size #732

liamsi opened this issue Aug 6, 2021 · 4 comments
Labels
specs directly relevant to the specs

Comments

@liamsi
Copy link
Member

liamsi commented Aug 6, 2021

We currently set the share size (rather arbitrarily) to 256 bytes. IMO this should be increased to maybe 1KB or more. Independent of what I think there must be a rationale document for the parameter choice explaining pros/cons and why we settled on whatever value.

@liamsi liamsi changed the title Potentially increase default share size Potentially increase share size Aug 6, 2021
@adlerjohn
Copy link
Member

To provide some additional context: since

  1. Requests with a reserved namespace ID are concatenated contiguously, and
  2. Messages are expected to be quite large, as they're supposed to be rollup blocks (i.e. transaction batches),

it makes sense to make the share size larger rather than smaller.

@musalbas
Copy link
Member

musalbas commented Dec 6, 2021

The main drawback of increasing the chunk size is that it makes data availability sampling more expensive, but we should do some calculations on this.

@adlerjohn adlerjohn removed their assignment Jan 8, 2022
@rootulp
Copy link
Collaborator

rootulp commented Aug 26, 2022

Related: #711

@adlerjohn adlerjohn transferred this issue from celestiaorg/celestia-specs Sep 19, 2022
@adlerjohn adlerjohn added the specs directly relevant to the specs label Sep 19, 2022
@rootulp
Copy link
Collaborator

rootulp commented Oct 31, 2022

Closed by #850

@rootulp rootulp closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specs directly relevant to the specs
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants