Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - More Error Reporting for Error "Object Not Found Matching Id" #4209

Closed
indeediansbrett opened this issue Aug 15, 2022 · 3 comments
Labels
feature-request Good First Issue good first issue Issues that are suitable for first-time contributors. up-for-grabs
Milestone

Comments

@indeediansbrett
Copy link

indeediansbrett commented Aug 15, 2022

Describe the solution you'd like
In JavascriptObjectRespitory there's an error thrown that says "Object Not Found Matching Id: objectId". We get this error on our Datadog logs, but have no idea what .net app that it came from or whom to contact regarding the issue. Is there any way to add additional context to the error? It would appear the user of this library is unregistering an object before it should be unregistered.

return new TryCallMethodResult(false, result, "Object Not Found Matching Id:" + objectId);

Describe alternatives you've considered
This is what we get on our end in Datadog, so really have next to little information to go off of:

Uncaught "Object Not Found Matching Id:6"
No stack, consider using an instance of Error

Additional context
Add any other context or screenshots about the feature request here.

@amaitland
Copy link
Member

You could easily add the method name and param count to the error message. Your welcome to submit a Pull Request.

@amaitland amaitland added up-for-grabs Good First Issue good first issue Issues that are suitable for first-time contributors. labels Aug 16, 2022
@indeediansbrett
Copy link
Author

Is there anything else we can add? Basically have people running our website inside their .net app, but we have no idea what .net app is running it. So we have zero traceability on how to prevent users from experiencing an error.

@amaitland amaitland added this to the 105.3.x milestone Aug 21, 2022
@amaitland
Copy link
Member

Providing details of the host application may have unforeseen security implications. For now adding method name and param count should help developers track errors.

I'd suggest trying to obtain a call stack for the error from your logging tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Good First Issue good first issue Issues that are suitable for first-time contributors. up-for-grabs
Projects
None yet
Development

No branches or pull requests

2 participants