From 0cca6c6161f0459016e96c264655aa25e6bcf737 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Thu, 7 May 2020 14:00:44 -0700 Subject: [PATCH] Update new nav categories to add Enterprise Search + update plugin to use new category - per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability --- src/core/utils/default_app_categories.ts | 12 ++++++++++-- x-pack/plugins/enterprise_search/public/plugin.ts | 4 +--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/core/utils/default_app_categories.ts b/src/core/utils/default_app_categories.ts index 5708bcfeac31a..cc9bfb1db04d5 100644 --- a/src/core/utils/default_app_categories.ts +++ b/src/core/utils/default_app_categories.ts @@ -29,20 +29,28 @@ export const DEFAULT_APP_CATEGORIES = Object.freeze({ euiIconType: 'logoKibana', order: 1000, }, + enterpriseSearch: { + id: 'enterpriseSearch', + label: i18n.translate('core.ui.enterpriseSearchNavList.label', { + defaultMessage: 'Enterprise Search', + }), + order: 2000, + euiIconType: 'logoEnterpriseSearch', + }, observability: { id: 'observability', label: i18n.translate('core.ui.observabilityNavList.label', { defaultMessage: 'Observability', }), euiIconType: 'logoObservability', - order: 2000, + order: 3000, }, security: { id: 'security', label: i18n.translate('core.ui.securityNavList.label', { defaultMessage: 'Security', }), - order: 3000, + order: 4000, euiIconType: 'logoSecurity', }, management: { diff --git a/x-pack/plugins/enterprise_search/public/plugin.ts b/x-pack/plugins/enterprise_search/public/plugin.ts index cf495b6a6f9de..ff1a78f1999cf 100644 --- a/x-pack/plugins/enterprise_search/public/plugin.ts +++ b/x-pack/plugins/enterprise_search/public/plugin.ts @@ -42,9 +42,7 @@ export class EnterpriseSearchPlugin implements Plugin { core.application.register({ id: 'enterprise_search', title: 'App Search', // TODO: This will eventually be 'Enterprise Search' once there's more than just App Search in here - euiIconType: AppSearchLogo, // TODO: Temporary - App Search will likely no longer need an icon once the nav structure changes. - category: DEFAULT_APP_CATEGORIES.management, // TODO - This is likely not final/correct - order: 10, // TODO - This will also likely not be needed once new nav structure changes land + category: DEFAULT_APP_CATEGORIES.enterpriseSearch, mount: async (params: AppMountParameters) => { const [coreStart] = await core.getStartServices();