Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #18

Closed
zamazan4ik opened this issue Dec 1, 2024 · 1 comment
Closed

Enable Link-Time Optimization (LTO) #18

zamazan4ik opened this issue Dec 1, 2024 · 1 comment

Comments

@zamazan4ik
Copy link

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance - the same observation was mentioned in a Maturin issue. If you want to read a bit more about LTO, I can recommend starting from this Rustc documentation.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the package. If we enable it on the Cargo profile level, users, who build the package manually will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

According to my quick local tests with the latest evmole version on Fedora 41 + Rustc 1.82, adding lto = true to the Release profile reduces the final wheel size from 313 Kib to 284 Kib (built with the maturin build --release command).

Thank you.

@cdump
Copy link
Owner

cdump commented Dec 2, 2024

Hi!

Thanks! It's been enabled in the master branch: 932284a

P.S. I tried using LTO some time ago but observed no changes in the benchmark results, so I didn’t enable it then. However, the reduction in size is a sufficient reason to enable it by default now.

@cdump cdump closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants