Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabel testing: number field #4851

Open
connorscarolyns opened this issue Dec 17, 2024 · 6 comments · May be fixed by #4897
Open

Fabel testing: number field #4851

connorscarolyns opened this issue Dec 17, 2024 · 6 comments · May be fixed by #4897
Assignees
Labels
a11y Accessibility related issue bug Something isn't working

Comments

@connorscarolyns
Copy link

Description

entry is being read oddly.

Voiveover in Safari

https://app.makeitfable.com/share/675ae655e9c0df46797459d2

@connorscarolyns connorscarolyns added the bug Something isn't working label Dec 17, 2024
@connorscarolyns connorscarolyns added the a11y Accessibility related issue label Dec 17, 2024
@thiessenp-cds
Copy link
Contributor

I was unable to reproduce the same issue the user encountered. I tried entering new numbers and also using the up-down arrow keys to increase-decrease the numbers. I could not get VO to announce the same pattern 0 followed by the new number.

I did find a different bug though in VO. Once the input stepper goes beyond 10, VO will only announce the first digit. For example, 22 would be announced as 2. This could be very confusing for mac users. Oddly it looks like Apple does not have a place to file and follow bug tickets. But they do have an email address - I emailed them...
e.g. https://www.digitala11y.com/how-where-to-report-accessibility-bugs/

Attached are some example videos.

Screen.Recording.2024-12-30.at.9.52.05.AM.mov
Screen.Recording.2024-12-30.at.9.54.05.AM.mov
Screen.Recording.2024-12-30.at.10.17.56.AM.mov

@connorscarolyns
Copy link
Author

I wonder if an improvement might be that we don't use the number stepper field and restrict the input only to accept numbers. There is limited usability benefits to having an incremental stepper, and there seems to be odd behaviour associated with it.

@thiessenp-cds
Copy link
Contributor

I wonder if an improvement might be that we don't use the number stepper field and restrict the input only to accept numbers. There is limited usability benefits to having an incremental stepper, and there seems to be odd behaviour associated with it.

Makes sense to me and also looks like the change would be inline with what the gov.uk design system is doing. @timarney can you see any problem with this change or additional background we may not know?

The solution could be replacing the

<input  type="number">
with something like 
<input type="text" inputmode="numeric" pattern="[0-9]*"> 

@timarney
Copy link
Member

timarney commented Jan 2, 2025

No concerns with not using a stepper

@srtalbot
Copy link
Contributor

srtalbot commented Jan 7, 2025

@connorscarolyns to test and validate

@ioanacontu
Copy link
Collaborator

@thiessenp-cds to make suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related issue bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants