Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create problem-list-item-create #430

Merged
merged 21 commits into from
Feb 2, 2024
Merged

create problem-list-item-create #430

merged 21 commits into from
Feb 2, 2024

Conversation

isaacvetter
Copy link
Member

Propose condition-create hook

@isaacvetter
create condition-create.md
9e60449 
Propose condition-create hook
@kpshek kpshek temporarily deployed to cds-hooks-docs-pr-430 November 15, 2018 22:17 Inactive
@kpshek kpshek temporarily deployed to cds-hooks-docs-pr-430 November 19, 2018 22:38 Inactive
@isaacvetter
Copy link
Member Author

Feedback from CDS wg: Should rename this to problem-list-create to distinguish between problist list entries and health concerns, etc.

@isaacvetter
restrict hook to problem
da31d17 
rename hook, adjust examples
@isaacvetter
rename hook
28207e1 
condition-create -> problem-list-create
@isaacvetter isaacvetter changed the title create condition-create.md create problem-list-create.md Jun 28, 2019
@jmandel
Copy link
Member

jmandel commented Jun 28, 2019

Love the idea. Naming-wise, why not call it condition-create as you did in the PR text? If you prefer "problem" to "condition," that's fine, but I'm confused by "list" -- since problem-list-create sounds like an operation to create a problem list, whereas this is an operation to create one or more problem(s) on a list.

@jmandel
Copy link
Member

jmandel commented Jun 28, 2019

(Similar to appointment-book.)

brynrhodes
brynrhodes requested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same feedback as Josh here, problem-list-create makes it sound like the hook is responding to the creation of a list of problems, suggest either problem-create or problem-list-item-create

@brynrhodes brynrhodes self-requested a review January 6, 2021 16:20
@isaacvetter isaacvetter changed the title create problem-list-create.md create problem-list-item-create Jun 14, 2023
@isaacvetter isaacvetter requested review from vadi2 and removed request for kpshek, jmandel, dennispatterson and brettmarquard June 14, 2023 17:08
@isaacvetter
Copy link
Member Author

CDS WG voted to merge this proposed hook into CI build today -- https://confluence.hl7.org/display/CDS/2023-06-14+-+Meeting+Agenda

@isaacvetter isaacvetter merged commit 45b12dc into master Feb 2, 2024
1 check passed
@isaacvetter isaacvetter deleted the propose-condition-create-hook branch February 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadi2 vadi2 vadi2 approved these changes

@brynrhodes brynrhodes brynrhodes approved these changes

Assignees
No one assigned
Labels
hooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isaacvetter @jmandel @vadi2 @brynrhodes @kpshek