Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch between small cones and big cones strategy in from_cones #164

Closed
ManonMarchand opened this issue Aug 2, 2024 · 4 comments · Fixed by #169
Closed

Switch between small cones and big cones strategy in from_cones #164

ManonMarchand opened this issue Aug 2, 2024 · 4 comments · Fixed by #169

Comments

@ManonMarchand
Copy link
Member

ManonMarchand commented Aug 2, 2024

We should think about a strategy to switch between the two algos.

@hombit benchmarked the small cone strategy (from MOC-cli) to be 7x faster for some use cases

TODO before: benchmark with systematic number of cells per cone variations at different depths to determine optimal switch points

@fxpineau
Copy link
Member

fxpineau commented Sep 4, 2024

@ManonMarchand (cc @hombit),
I just added a from_small_cones method (returning a single MOC) in the Rust wrapper.
See commit 8ddb6eb.

@fxpineau
Copy link
Member

fxpineau commented Sep 4, 2024

(Note that I added a multi-threaded version of from_small_cones, to be tested, in moc-lib-rust. See this commit)

@ManonMarchand
Copy link
Member Author

ManonMarchand commented Sep 11, 2024

Will be more complete with #174
We decided that switching automatically would be clumsy, so the choice is for the user. There is a new keyword in from_cones and in from_boxes that allows to chose between small and large strategy. The small one will usually be faster if the shapes don't overlap.

@hombit
Copy link

hombit commented Sep 11, 2024

Sounds great, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants