Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon-set): introduce L2 #504

Merged
merged 5 commits into from
Apr 4, 2022
Merged

feat(daemon-set): introduce L2 #504

merged 5 commits into from
Apr 4, 2022

Conversation

iliapolo
Copy link
Member

Resolves #375

Note that I intentionally only added support for pod spec and minReadySeconds to get something out quickly.
Other properties will be added at a later time.

Signed-off-by: iliapolo <epolon@amazon.com>
@iliapolo iliapolo requested a review from a team March 31, 2022 17:16
@iliapolo iliapolo changed the title feat: daemon set feat(daemon-set): introduce L2 Apr 3, 2022
@iliapolo iliapolo self-assigned this Apr 4, 2022
Comment on lines +36 to +39
* A DaemonSet ensures that all (or some) Nodes run a copy of a Pod.
* As nodes are added to the cluster, Pods are added to them.
* As nodes are removed from the cluster, those Pods are garbage collected.
* Deleting a DaemonSet will clean up the Pods it created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful description 🙌

@mergify mergify bot merged commit fbc9f0a into k8s-22/main Apr 4, 2022
@mergify mergify bot deleted the epolon/daemon-set branch April 4, 2022 20:42
@cdk8s-automation
Copy link
Contributor

The backport to k8s-21/main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-k8s-21/main k8s-21/main
# Navigate to the new working tree
cd .worktrees/backport-k8s-21/main
# Create a new branch
git switch --create backport-504-to-k8s-21/main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 fbc9f0ad4d8318a8d11d47186f7f55c69e0466ba
# Push it to GitHub
git push --set-upstream origin backport-504-to-k8s-21/main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-k8s-21/main

Then, create a pull request where the base branch is k8s-21/main and the compare/head branch is backport-504-to-k8s-21/main.

@cdk8s-automation
Copy link
Contributor

The backport to k8s-20/main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-k8s-20/main k8s-20/main
# Navigate to the new working tree
cd .worktrees/backport-k8s-20/main
# Create a new branch
git switch --create backport-504-to-k8s-20/main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 fbc9f0ad4d8318a8d11d47186f7f55c69e0466ba
# Push it to GitHub
git push --set-upstream origin backport-504-to-k8s-20/main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-k8s-20/main

Then, create a pull request where the base branch is k8s-20/main and the compare/head branch is backport-504-to-k8s-20/main.

iliapolo added a commit that referenced this pull request Apr 13, 2022
Resolves #375

Note that I intentionally only added support for pod spec and `minReadySeconds` to get something out quickly.
Other properties will be added at a later time.

(cherry picked from commit fbc9f0a)
Signed-off-by: Eli Polonsky <epolon@amazon.com>

# Conflicts:
#	docs/java.md
#	docs/python.md
#	docs/typescript.md
@iliapolo
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
k8s-21/main

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Apr 13, 2022
Resolves #375

Note that I intentionally only added support for pod spec and `minReadySeconds` to get something out quickly.
Other properties will be added at a later time.

(cherry picked from commit fbc9f0a)
Signed-off-by: Eli Polonsky <epolon@amazon.com>

# Conflicts:
#	docs/java.md
#	docs/python.md
#	docs/typescript.md
@iliapolo
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
k8s-20/main

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Apr 13, 2022
Resolves #375

Note that I intentionally only added support for pod spec and `minReadySeconds` to get something out quickly.
Other properties will be added at a later time.

(cherry picked from commit fbc9f0a)
Signed-off-by: Eli Polonsky <epolon@amazon.com>

# Conflicts:
#	docs/java.md
#	docs/python.md
#	docs/typescript.md
iliapolo added a commit that referenced this pull request Apr 13, 2022
Resolves #375

Note that I intentionally only added support for pod spec and `minReadySeconds` to get something out quickly.
Other properties will be added at a later time.

(cherry picked from commit fbc9f0a)
Signed-off-by: Eli Polonsky <epolon@amazon.com>

# Conflicts:
#	docs/java.md
#	docs/python.md
#	docs/typescript.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DaemonSet L2
3 participants