Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

/v1/thumbs should time out eventually #602

Closed
aldenstpage opened this issue Aug 26, 2020 · 3 comments
Closed

/v1/thumbs should time out eventually #602

aldenstpage opened this issue Aug 26, 2020 · 3 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🙅 status: discontinued Not suitable for work as repo is in maintenance

Comments

@aldenstpage
Copy link
Contributor

Description

If we are having a hard time loading a 3rd party image through our proxy, we should give up thumbnailing it. The frontend will fall back to the full sized image.

If we can't answer thumbnail requests quickly enough, our servers' workers become swamped with thumbnailing requests.

@aldenstpage aldenstpage added 🏁 status: ready for work Ready for work 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon labels Sep 14, 2020
@tushar912
Copy link
Contributor

@aldenstpage I would like to work on this. Can u explain this issue a bit.

@aldenstpage
Copy link
Contributor Author

Hi @tushar912, I'd be happy to answer any specific questions you have about the ticket

@kgodey kgodey removed the bug label Sep 24, 2020
@manav1403
Copy link

manav1403 commented Oct 11, 2020

@aldenstpage Is it correct that for this issue we have to set a timeout on request when full size is false and if the request exceeds timeout then send the response of the full-sized image
and what should be the value of the timeout?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🙅 status: discontinued Not suitable for work as repo is in maintenance
Development

No branches or pull requests

4 participants