Support autofix in golangici-lint

[mitar]

This would be great, so that linter could just autofix the issues.

[catenacyber]

It is already there, like perfsprint -h shows you the flag like fix

[mitar]

Hm, it is not in golangci-lint:

perfsprint: Checks that fmt.Sprintf can be replaced with a faster alternative. [fast: false, auto-fix: false]

[ccoVeille]

I think you are looking for

• Add support for SuggestedFixes golangci/golangci-lint#1779

[mitar]

So the issue is that golangci-lint does not support SuggestedFixes, but some other linters are doing auto-fixing in some other way then?

[ccoVeille]

Yes, so it's not an issue that can be addressed in perfsprint

And the ticket already exists in golangci-lint

I'm unsure what is the latest status. I mean I'm unsure if they were not awaiting something to be merged in Go std lib

[mitar]

Thanks.

[catenacyber]

Thanks Christophe for answering better and faster than me

[ccoVeille]

Unless ... I was totally wrong

golangci/golangci-lint#4994 (comment)

Here is what is recommended apparently https://github.com/4meepo/tagalign/blob/e25313ba1e10f624375cf2573cdcf07473178606/tagalign.go#L163-L173

I think I had also misunderstood and expected golangci-lint to support suggestedfixes, but it's the opposite, it might be to each linter to support the golangci-lint format

[mitar]

I mean, or we wait for golangci-lint to support suggestedfixes, or this linter implements custom API golangci-lint requires now.

[ccoVeille]

Exactly. But I think it's a simpler move to try supporting the golangci-lint mode maybe

[catenacyber]

a PR is welcome if you want golangci-lint mode :-)

[mitar]

Let's then reopen this.