Add to string for std::optional #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmoussu
force-pushed
the
dev/optional_tostring
branch
from
c4f5f78
to
1469351
Compare
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 80.38% 80.41% +0.03%
==========================================
Files 121 121
Lines 3409 3404 -5
==========================================
- Hits 2740 2737 -3
+ Misses 669 667 -2 |
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
=======================================
Coverage 80.53% 80.53%
=======================================
Files 121 121
Lines 3436 3436
=======================================
Hits 2767 2767
Misses 669 669 |
horenmar
reviewed
Jan 25, 2019
horenmar
reviewed
Jan 25, 2019
|
Where did the tests go? |
robinmoussu
force-pushed
the
dev/optional_tostring
branch
from
e8a3dcd
to
72b33a1
Compare
|
The new flag should also be added to |
horenmar
reviewed
Jan 26, 2019
robinmoussu
force-pushed
the
dev/optional_tostring
branch
from
72b33a1
to
773de5b
Compare
|
I am just gonna merge it and add the documentation myself. |
horenmar
added a commit
that referenced
this pull request
Jan 31, 2019
|
Thanks, I was going to do it, but I'm glad you did it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add stringification for c++17
std::optional.I used the same style than
std::variant<std::monostate>for empty optionals ({ }), and no curly bracket around valid object (example:0or"abc"). See the added unit tests.Given that this is a feature conditionally activated (if C++17 is available), then I don't know if the files modified by the script
misc/CMakeLists.txtshould be added.