Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Meridiem buttons can sometimes change selected minute. #73

Closed
mac-s-g opened this issue Jul 20, 2021 · 0 comments · Fixed by #80
Closed

Clicking Meridiem buttons can sometimes change selected minute. #73

mac-s-g opened this issue Jul 20, 2021 · 0 comments · Fixed by #80

Comments

@mac-s-g
Copy link

mac-s-g commented Jul 20, 2021

first and foremost - thank you to the authors for building an amazing component and sharing it with the community.

I encountered an intermittent issue where attempting to click the circular meridiem buttons unintentionally changes the selected hour or minute value.

here's an example:

time-keeper-meridiem-btn-issue.mp4

I eventually realized the problem occurs when my mouse drags during the button click.

In other words, 1 or more pixels of mouse movement between mouse down and mouse up causes the intended meridiem button click to be interpreted as a clock hand drag.

The issue can be hard to avoid when mouse sensitivity is high.

One possible solution would be to disable clock hand drag when the target of mouse down is a meridiem button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant