Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When crawling a batch can go in circles for a long time if it cannot do anything (eg broken locks) #197

Open
2 tasks
brendanheywood opened this issue Feb 4, 2025 · 0 comments

Comments

@brendanheywood
Copy link
Contributor

The crawler grabs a batch of 1000 rows, loops over them, if it can't get a lock then it moves on. But if it goes through the whole batch and doesn't get any locks it grabs the same batch again and just keeps looping.

In practice this isn't a big deal unless there is a broken lock and the queue is actually small so maybe this is more prevalent on a dev box.

  • Need some sort of lock cleanup the same as cron task cleanup?
  • Need to detect if the batch loop has done nothing and exit early
@brendanheywood brendanheywood changed the title When crawling a batch can go in circles for a long time if it cannot do anything When crawling a batch can go in circles for a long time if it cannot do anything (eg broken locks) Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant