From 1210404a462cf833de8e51f7f0c93d3f30194692 Mon Sep 17 00:00:00 2001
From: Kevin Pham <keevan.pham@gmail.com>
Date: Tue, 10 Dec 2024 15:02:09 +1100
Subject: [PATCH] fix: set the tempdirdefault on the setting itself instead of
 inside a lang string

---
 lang/en/auth_saml2.php | 1 -
 settings.php           | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/lang/en/auth_saml2.php b/lang/en/auth_saml2.php
index a2ca5ebea..55ae16538 100644
--- a/lang/en/auth_saml2.php
+++ b/lang/en/auth_saml2.php
@@ -205,7 +205,6 @@
 $string['taskmetadatarefresh'] = 'Metadata refresh task';
 $string['tempdir'] = 'SimpleSAMLphp temporary directory';
 $string['tempdir_help'] = 'A directory where SimpleSAMLphp can save temporary files';
-$string['tempdirdefault'] = '/tmp/simplesaml';
 $string['test_auth_button_login'] = 'IdP Login';
 $string['test_auth_button_logout'] = 'IdP Logout';
 $string['test_auth_str'] = 'Test isAuthenticated and login';
diff --git a/settings.php b/settings.php
index 93ac2ee9a..3760ece1a 100644
--- a/settings.php
+++ b/settings.php
@@ -367,12 +367,12 @@
         1,
         $yesno));
 
-    // SAMLPHP tempdir
+    // SAMLPHP tempdir.
     $settings->add(new admin_setting_configtext(
         'auth_saml2/tempdir',
         get_string('tempdir', 'auth_saml2'),
         get_string('tempdir_help', 'auth_saml2'),
-        get_string('tempdirdefault', 'auth_saml2'),
+        '/tmp/simplesaml',
         PARAM_TEXT,
         50,
         3));