Length cutoff: SpladePlusPlusEnsembleDistilEncoder vs. SpladePlusPlusSelfDistilEncoder

[lintool]

Why does SpladePlusPlusEnsembleDistilEncoder have a max seq length cutoff?
https://github.com/castorini/anserini/blob/master/src/main/java/io/anserini/encoder/sparse/SpladePlusPlusEnsembleDistilEncoder.java#L69

And SpladePlusPlusSelfDistilEncoder doesn't?
https://github.com/castorini/anserini/blob/master/src/main/java/io/anserini/encoder/sparse/SpladePlusPlusSelfDistilEncoder.java#L67

@ArthurChen189 this is your impl right? Was this just an oversight?

@cadurosar wanted to check with you also... both models should have a 512 length cutoff? So it's a bug in our impl?

[ArthurChen189]

Should be an oversight.

iirc, I added one MAX_SEQ_LEN because only Splade++ ED failed the regression issue (#2368). According to HF config, both models should have MAX_SEQ_LEN=512.

[lintool]

Closed by #2761